git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: suggest --amend --reset-author to fix commiter identity
Date: Sat, 08 Jan 2011 11:56:00 +0100	[thread overview]
Message-ID: <vpq1v4nirzz.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vsjx45w7g.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Fri\, 07 Jan 2011 11\:51\:15 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> I don't think making the "cheat-sheet" insn longer by offering more
> choices is a good idea.  These are messages for lazy and busy
> people.

The reason I kept both forms was that the message is designed to be
seen once (or once for each new machine one works on), and the most
scary it is, the most efficient ;-). 

> Wouldn't it work better to just get rid of the longer form and say
> something like:
>
>     ... here is how to tell your name to git (existing message) ...
>
>     After doing the above, run
>
>     	git commit --amend --reset-author
>
>     to fix the identity used for this commit.

I'm fine with that proposal too. I'll resend with that if no one
objects. Probalby rewording it to

After doing this, you can fix the identity used for this commit with:

  git commit --amend --reset-author


would make it even concisier (no break of the sentence with a
command).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2011-01-08 10:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-07 14:14 [PATCH] commit: suggest --amend --reset-author to fix commiter identity Matthieu Moy
2011-01-07 17:13 ` Jonathan Nieder
2011-01-07 17:16   ` Matthieu Moy
2011-01-07 17:34     ` Jonathan Nieder
2011-01-07 19:51 ` Junio C Hamano
2011-01-08 10:56   ` Matthieu Moy [this message]
2011-01-11  5:34     ` Jeff King
2011-01-11 14:07     ` Matthieu Moy
2011-01-12 18:29       ` [PATCH v2] " Matthieu Moy
2011-01-12 18:39         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpq1v4nirzz.fsf@bauges.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).