From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jan Smets <jan.smets@alcatel-lucent.com>, <git@vger.kernel.org>
Subject: Re: repository corruption when pushing commits to a repository running 'git gc --prune='
Date: Wed, 14 Oct 2015 22:08:36 +0200 [thread overview]
Message-ID: <vpq37xd8b7f.fsf@grenoble-inp.fr> (raw)
In-Reply-To: <xmqq7fmp8bcf.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Wed, 14 Oct 2015 13:05:36 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> This looks like a race between deleting objects/05/ and creating
>> objects/05/cdb51bb0ea3e229734a4b1bddd5ec70fbc65ed.
>>
>> I don't understand how this is possible, since the temporary file and
>> the final one are in the same directory, so deleting the directory
>> should fail.
>>
>> What am I missing?
>
> 1. tmp_obj_* gets created in objects/05/ by "git unpack-objects";
>
> 2. prune_cruft() comes, notices tmp_obj_* that is sufficiently old,
> decides to remove in "git prune".
Ah, OK, the real problem is the temporary file removal. Thanks.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2015-10-14 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 13:44 repository corruption when pushing commits to a repository running 'git gc --prune=' Jan Smets
2015-10-14 14:38 ` Matthieu Moy
2015-10-14 17:37 ` Junio C Hamano
2015-10-14 18:40 ` Matthieu Moy
2015-10-14 20:48 ` Junio C Hamano
2015-10-14 21:09 ` Matthieu Moy
2015-10-14 21:39 ` Junio C Hamano
2015-10-14 18:46 ` Matthieu Moy
2015-10-14 20:05 ` Junio C Hamano
2015-10-14 20:08 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq37xd8b7f.fsf@grenoble-inp.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jan.smets@alcatel-lucent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).