From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Javier.Roucher-Iglesias@ensimag.imag.fr
Cc: git@vger.kernel.org, Javier Roucher <jroucher@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH/RFC] Add 'git credential' plumbing command
Date: Tue, 12 Jun 2012 16:31:33 +0200 [thread overview]
Message-ID: <vpq3960r48q.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1339511044-29977-1-git-send-email-Javier.Roucher-Iglesias@ensimag.imag.fr> (Javier Roucher-Iglesias's message of "Tue, 12 Jun 2012 16:24:04 +0200")
Javier.Roucher-Iglesias@ensimag.imag.fr writes:
> +git credential <fill|approve|reject>
You didn't take Jeff's suggestions into account:
http://thread.gmane.org/gmane.comp.version-control.git/199552/focus=199591
It's clearly too late to implement the whole suggested API, but I do
like the suggestion of allowing either a URL as argument or individual
fields on stdin, or both combined, by using the --stdin argument.
To allow further patches to implement this without breaking backward
compatibility, your implementation could require the use of --stdin on
the command-line.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2012-06-12 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 14:24 [PATCH/RFC] Add 'git credential' plumbing command Javier.Roucher-Iglesias
2012-06-12 14:31 ` Matthieu Moy [this message]
2012-06-12 14:34 ` Jeff King
2012-06-12 14:36 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq3960r48q.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Javier.Roucher-Iglesias@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=jroucher@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox