From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: vireshk <viresh.kumar@st.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>
Subject: Re: Issue: Mails sent twice if patch is mentioned twice while sending mail.
Date: Wed, 17 Aug 2011 11:58:49 +0200 [thread overview]
Message-ID: <vpq62lwjr52.fsf@bauges.imag.fr> (raw)
In-Reply-To: <4E4B86F1.2010802@st.com> (vireshk's message of "Wed, 17 Aug 2011 14:46:33 +0530")
vireshk <viresh.kumar@st.com> writes:
> Hi Ram,
>
> Actually i did this by mistake once and thought git send-email should
> have taken care of this. I may be wrong, but it was just an thought.
git send-email could probably issue a warning if the same patch is
mentionned twice, but I don't think it's sane to try to silently
autocorrect user's mistake.
If users get used to "git send-email 1.patch 1.patch" sending the email
only once, then what should be the expected behavior of
git send-email 1.patch ./1.patch
git send-email 1.patch symlink-to-1.patch
?
The nice thing with a warning is that you can't really blame the tool
for not issuing a warning, while it can be harmfull to have an
autocorrection fail in a real user-senario.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2011-08-17 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 6:11 Issue: Mails sent twice if patch is mentioned twice while sending mail viresh kumar
2011-08-17 8:52 ` Ramkumar Ramachandra
2011-08-17 9:16 ` vireshk
2011-08-17 9:58 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq62lwjr52.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=shiraz.hashim@st.com \
--cc=vipin.kumar@st.com \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox