From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCHv2] Makefile: add missing phony target Date: Fri, 11 Dec 2015 15:40:49 +0100 Message-ID: References: <1449843766-41658-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org To: Elia Pinto X-From: git-owner@vger.kernel.org Fri Dec 11 15:40:58 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7OsS-00047Q-Ur for gcvg-git-2@plane.gmane.org; Fri, 11 Dec 2015 15:40:57 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717AbbLKOkx (ORCPT ); Fri, 11 Dec 2015 09:40:53 -0500 Received: from mx1.imag.fr ([129.88.30.5]:39989 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbbLKOkw (ORCPT ); Fri, 11 Dec 2015 09:40:52 -0500 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id tBBEelk4006068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 11 Dec 2015 15:40:48 +0100 Received: from anie (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id tBBEen0s013833; Fri, 11 Dec 2015 15:40:49 +0100 In-Reply-To: <1449843766-41658-1-git-send-email-gitter.spiros@gmail.com> (Elia Pinto's message of "Fri, 11 Dec 2015 14:22:46 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Fri, 11 Dec 2015 15:40:48 +0100 (CET) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: tBBEelk4006068 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1450449648.26048@LlGccz3EFeiesIqwVx0ceQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Elia Pinto writes: > This is the second version of this patch. > Added the corrections suggested by Matthieu Moy ($gmane/282221) Sorry, but my main concern was that the patch could not be reviewed in good conditions as-is, and I think it still cannot be. It's very hard to spot which .PHONY rules you're adding and which are just code movement. You should really split this into one "code movement" patch and one "actual bugfix" patch. Or someone with better eyes than me should review the patch ;-). > @@ -2215,6 +2221,7 @@ test-svn-fe$X: vcs-svn/lib.a > test-%$X: test-%.o GIT-LDFLAGS $(GITLIBS) > $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(filter %.a,$^) $(LIBS) > > +.PHONY: check_sha1 $(SP_OBJ) sparse check check-sha1 > check-sha1:: test-sha1$X > ./test-sha1.sh > > @@ -2224,7 +2231,6 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE > $(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \ > $(SPARSE_FLAGS) $< > > -.PHONY: sparse $(SP_OBJ) > sparse: $(SP_OBJ) This "sparse" movement looks again contradictory with the goal announced in the commit message. > @@ -2237,6 +2243,7 @@ check: common-cmds.h > exit 1; \ > fi > > + > ### Installation rules Useless hunk. -- Matthieu Moy http://www-verimag.imag.fr/~moy/