From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Cc: Git List <git@vger.kernel.org>,
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH/RFCv5 3/3] git rebase -i: add static check for commands and SHA-1
Date: Wed, 10 Jun 2015 18:08:15 +0200 [thread overview]
Message-ID: <vpqa8w71r80.fsf@anie.imag.fr> (raw)
In-Reply-To: <58099623.334723.1433951804504.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Remi Galan Alfonso's message of "Wed, 10 Jun 2015 17:56:44 +0200 (CEST)")
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
> It is mainly because here the SHA-1 is a long one (40 chars)
OK, but then the minimum would be to add a comment saying that.
Now, this makes me wonder why you are doing the check after the sha1
expansion and not before. Also, when running `git bisect --edit-todo`, I
do get the short sha1. So, there's a piece of code doing what you want
somewhere already. You may want to use it.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-10 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 10:10 [PATCH/RFCv5 1/3] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-10 10:10 ` [PATCH/RFCv5 2/3] git rebase -i: warn about removed commits Galan Rémi
2015-06-10 14:53 ` Matthieu Moy
2015-06-10 15:47 ` Remi Galan Alfonso
2015-06-10 15:55 ` Matthieu Moy
2015-06-10 15:59 ` Remi Galan Alfonso
2015-06-10 10:10 ` [PATCH/RFCv5 3/3] git rebase -i: add static check for commands and SHA-1 Galan Rémi
2015-06-10 15:20 ` Matthieu Moy
2015-06-10 15:56 ` Remi Galan Alfonso
2015-06-10 16:08 ` Matthieu Moy [this message]
2015-06-13 23:17 ` Remi Galan Alfonso
2015-06-15 8:25 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqa8w71r80.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).