From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH/RFCv5 3/3] git rebase -i: add static check for commands and SHA-1 Date: Wed, 10 Jun 2015 18:08:15 +0200 Message-ID: References: <1433931035-20011-1-git-send-email-remi.galan-alfonso@ensimag.grenoble-inp.fr> <1433931035-20011-3-git-send-email-remi.galan-alfonso@ensimag.grenoble-inp.fr> <58099623.334723.1433951804504.JavaMail.zimbra@ensimag.grenoble-inp.fr> Mime-Version: 1.0 Content-Type: text/plain Cc: Git List , Remi Lespinet , Guillaume Pages , Louis-Alexandre Stuber , Antoine Delaite , Junio C Hamano , Eric Sunshine To: Remi Galan Alfonso X-From: git-owner@vger.kernel.org Wed Jun 10 18:08:37 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z2iYO-0006JM-MJ for gcvg-git-2@plane.gmane.org; Wed, 10 Jun 2015 18:08:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966650AbbFJQIa (ORCPT ); Wed, 10 Jun 2015 12:08:30 -0400 Received: from mx1.imag.fr ([129.88.30.5]:46959 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965355AbbFJQIZ (ORCPT ); Wed, 10 Jun 2015 12:08:25 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id t5AG8Eu3001053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 10 Jun 2015 18:08:14 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t5AG8FVR025671; Wed, 10 Jun 2015 18:08:15 +0200 In-Reply-To: <58099623.334723.1433951804504.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Remi Galan Alfonso's message of "Wed, 10 Jun 2015 17:56:44 +0200 (CEST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 10 Jun 2015 18:08:14 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t5AG8Eu3001053 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1434557297.60595@io0C5gqdlH8J/YAYKclJOQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Remi Galan Alfonso writes: > It is mainly because here the SHA-1 is a long one (40 chars) OK, but then the minimum would be to add a comment saying that. Now, this makes me wonder why you are doing the check after the sha1 expansion and not before. Also, when running `git bisect --edit-todo`, I do get the short sha1. So, there's a piece of code doing what you want somewhere already. You may want to use it. -- Matthieu Moy http://www-verimag.imag.fr/~moy/