From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions
Date: Mon, 20 Apr 2015 13:03:30 +0200 [thread overview]
Message-ID: <vpqa8y3giyl.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqq8udrizmk.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 16 Apr 2015 13:31:31 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Elia Pinto <gitter.spiros@gmail.com> writes:
>>
>>> --- a/t/test-lib-functions.sh
>>> +++ b/t/test-lib-functions.sh
>>> @@ -478,7 +478,7 @@ test_external_without_stderr () {
>>> test_path_is_file () {
>>> if ! test -f "$1"
>>> then
>>> - echo "File $1 doesn't exist. $*"
>>> + echo "File $1 doesn't exist. $2"
>>> false
>>> fi
>>> }
>>> @@ -486,7 +486,7 @@ test_path_is_file () {
>>> test_path_is_dir () {
>>> if ! test -d "$1"
>>> then
>>> - echo "Directory $1 doesn't exist. $*"
>>> + echo "Directory $1 doesn't exist. $2"
>>> false
>>> fi
>>> }
>>
>> Sounds straightforwardly correct to me.
>
> Thanks. This however makes me wonder why you were nominated for
> reviewing this patch, though...
It seems I'm the one who introduced the bug indeed, in 2caf20c52b7f6.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2015-04-20 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 14:12 [PATCH] test-lib-functions.sh: fix the second argument to some helper functions Elia Pinto
2015-04-16 14:38 ` Matthieu Moy
2015-04-16 20:31 ` Junio C Hamano
2015-04-20 11:03 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqa8y3giyl.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).