From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jens Lehmann <Jens.Lehmann@web.de>, git <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] mv: Fix spurious warning when moving a file in presence of submodules
Date: Mon, 14 Oct 2013 14:33:57 +0200 [thread overview]
Message-ID: <vpqfvs42fre.fsf@anie.imag.fr> (raw)
In-Reply-To: <20131014054048.GC25344@google.com> (Jonathan Nieder's message of "Sun, 13 Oct 2013 22:40:48 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Matthieu Moy wrote:
>> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>>> static struct lock_file lock_file;
>>> +#define SUBMODULE_WITH_GITDIR ((const char *)1)
>>
>> I don't like very much hardcoded addresses like this. Are you 100% sure
>> address 1 will never be returned by xstrdup on any platform? The risk is
>> small if not negligible, but I'm unconfortable with this.
>
> I haven't checked what the standards say, but in practice I think it's
> okay. [...] We use (void *) 1 in the same way a few places currently.
OK, fine with me.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-10-14 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 14:29 Spurious warning when moving a file in presence of submodules Matthieu Moy
2013-10-11 17:53 ` Jens Lehmann
2013-10-13 11:52 ` [PATCH] mv: Fix spurious " Jens Lehmann
2013-10-13 15:05 ` Matthieu Moy
2013-10-13 18:37 ` Jens Lehmann
2013-10-14 5:40 ` Jonathan Nieder
2013-10-14 12:33 ` Matthieu Moy [this message]
2013-10-17 18:24 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqfvs42fre.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).