From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, jrnieder@gmail.com, judge.packham@gmail.com,
gitster@pobox.com
Subject: Re: [PATCH v3 2/2] submodule: don't print status output with ignore=all
Date: Thu, 05 Sep 2013 08:30:53 +0200 [thread overview]
Message-ID: <vpqioyf231e.fsf@anie.imag.fr> (raw)
In-Reply-To: <52279ACC.2070308@web.de> (Jens Lehmann's message of "Wed, 04 Sep 2013 22:40:44 +0200")
Jens Lehmann <Jens.Lehmann@web.de> writes:
> Am 04.09.2013 08:31, schrieb Matthieu Moy:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>
>>> Tests are included which verify that this change has no effect on git submodule
>>> summary without the --for-status option.
>>
>> I still don't understand why this is needed.
>
> To avoid a change in behavior for "git submodule summary", as that
> never honored the submodule.*.ignore nor the diff.ignoreSubmodules
> setting (and I don't think it ever should).
I don't get it. If the goal is to keep the old behavior, then "git
status" shouldn't be changed either. Fixing bugs needs to change the
behavior.
IOW, why was it a bug that "git status" showed ignored submodules and
not a bug that "git submodule summary" did the same?
> Fine by me, what would you propose to clarify that? (Though I have the
> suspicion that the explanation will be three years late ;-)
I have no idea, as I do not understand the reason myself yet. I'm not a
frequent user of submodules and not a user of the ignore option at all,
so I can't tell what's best. I'd just like the new behavior to be
justified somewhere.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-09-05 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 20:06 [PATCH v3 0/2] submodule: Don't print status output with submodule.<name>.ignore=all brian m. carlson
2013-09-01 20:06 ` [PATCH v3 1/2] submodule: fix confusing variable name brian m. carlson
2013-09-01 20:06 ` [PATCH v3 2/2] submodule: don't print status output with ignore=all brian m. carlson
2013-09-03 19:17 ` Jens Lehmann
2013-09-03 19:53 ` Junio C Hamano
2013-09-04 20:01 ` Jens Lehmann
2013-09-04 20:57 ` Junio C Hamano
2013-09-04 21:26 ` Jens Lehmann
2013-09-04 6:31 ` Matthieu Moy
2013-09-04 20:40 ` Jens Lehmann
2013-09-05 6:30 ` Matthieu Moy [this message]
2013-09-05 8:05 ` Matthieu Moy
2013-09-06 0:19 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqioyf231e.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=judge.packham@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).