git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] trailer: ignore first line of message
Date: Fri, 21 Aug 2015 09:01:34 +0200	[thread overview]
Message-ID: <vpqk2sprupd.fsf@anie.imag.fr> (raw)
In-Reply-To: <1440107955-26892-1-git-send-email-chriscool@tuxfamily.org> (Christian Couder's message of "Thu, 20 Aug 2015 23:59:15 +0200")

Christian Couder <christian.couder@gmail.com> writes:

> When looking for the start of the trailers in the message
> we are passed, we should ignore the first line of the message.

Thanks, this fixes my issue.

There's one more corner-case I've just thought of:

git commit -m 'place of
code: change we made'

(with the line break)

Git considers this message as a summary line broken in the middle. "git
log --oneline" shows it as a one-liner, as if it were
'place of code: change we made'.

Even with your patch, the trailer is added without a blank line, and
renders on the subject line in `git log --oneline`. My command above
with a commit-msg hook outputs:

[master 86f32d5] place of: code: change we made Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>

(on a single line)

I do not care deeply, but you may want to let interpret-trailers deal
with this case too.

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

      reply	other threads:[~2015-08-21  7:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 16:37 Minor annoyance with 'git interpret-trailers' Matthieu Moy
2015-08-20 16:53 ` Christian Couder
2015-08-20 21:59   ` [PATCH] trailer: ignore first line of message Christian Couder
2015-08-21  7:01     ` Matthieu Moy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqk2sprupd.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).