From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: benoit.person@ensimag.fr
Cc: git@vger.kernel.org, Celestin Matte <celestin.matte@ensimag.fr>
Subject: Re: [PATCH] git-remote-mediawiki: remove hardcoded version number in the test suite
Date: Thu, 13 Jun 2013 13:38:18 +0200 [thread overview]
Message-ID: <vpqk3lytf4l.fsf@anie.imag.fr> (raw)
In-Reply-To: <1371123008-28068-1-git-send-email-benoit.person@ensimag.fr> (benoit person's message of "Thu, 13 Jun 2013 13:30:08 +0200")
benoit.person@ensimag.fr writes:
> Updates the code to make it more easy to switch mediawiki version when
> testing. Before that, the version number was partly hardcoded, partly
> in a var.
This is obviously good.
> Maybe I should add a warning that the installation procedure may not work
> in the future ? It seems to work for the range 1.19.X - 1.21.X though :) ?
> Should I also update the version number to the latest one (1.21.1) ?
This kind of remarks does not belong to the commit message, it should be
below the --- (before the diffstat).
And yes, I think a comment saying "# Versions foo, bar and boz have been
tested" or so would be welcome.
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2013-06-13 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 11:30 [PATCH] git-remote-mediawiki: remove hardcoded version number in the test suite benoit.person
2013-06-13 11:38 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqk3lytf4l.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).