From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Gerald Gutierrez <ggmlfs@gmail.com>,
git@vger.kernel.org
Subject: Re: git with custom diff for commits
Date: Tue, 18 Dec 2007 09:57:48 +0100 [thread overview]
Message-ID: <vpqk5ncz8fn.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vbq8o6gxw.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 17 Dec 2007 15\:26\:51 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>>> It will show an empty output for "git diff", but I doubt thit will
>>> change anything at commit time. Probably the "filter" thing on the same
>>> file (also "man gitattributes") can help though.
>>
>> Ah, right. I completely missed that you were talking about git-commit,
>> not git-log on git commits.
>>
>> Yes, setting up a "clean" filter that removes the timestamps is probably
>> the reasonable thing to do here.
>
> I wouldn't do filters for something like that. Can you guarantee that
> the output from corresopnding smudge filter will load cleanly back to
> the mysql database?
The original poster said the date was an SQL comment, so, it should be
safe to strip it. That said, precommit hook is probably a good or
better solution. At least, if you're not sure you didn't make a
mistake writting it, you'll notice either a good commit or no commit
at all. With filters, you might well notice you corrupted the commit
too late :-(.
--
Matthieu
next prev parent reply other threads:[~2007-12-18 9:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 22:56 git with custom diff for commits Gerald Gutierrez
2007-12-17 23:01 ` Johannes Schindelin
2007-12-17 23:08 ` Matthieu Moy
2007-12-17 23:11 ` Johannes Schindelin
2007-12-17 23:26 ` Junio C Hamano
2007-12-18 8:57 ` Matthieu Moy [this message]
2007-12-18 9:25 ` Junio C Hamano
2007-12-18 20:35 ` Gerald Gutierrez
2007-12-18 20:40 ` Junio C Hamano
2007-12-18 20:48 ` Gerald Gutierrez
2007-12-18 21:27 ` Johannes Schindelin
2007-12-18 21:51 ` Gerald Gutierrez
2007-12-18 22:00 ` Johannes Schindelin
2007-12-18 21:38 ` Junio C Hamano
2007-12-18 21:51 ` Matthieu Moy
2007-12-18 22:27 ` Gerald Gutierrez
2007-12-18 22:48 ` Johannes Schindelin
2007-12-18 23:52 ` Martin Langhoff
2007-12-19 9:01 ` Matthieu Moy
2007-12-19 12:09 ` Johannes Schindelin
2007-12-19 12:13 ` Matthieu Moy
2007-12-19 9:13 ` Matthieu Moy
2007-12-18 22:29 ` Gerald Gutierrez
2007-12-17 23:27 ` Gerald Gutierrez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqk5ncz8fn.fsf@bauges.imag.fr \
--to=matthieu.moy@imag.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=ggmlfs@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).