From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] revert: prettify fatal messages
Date: Tue, 15 Nov 2011 11:04:35 +0100 [thread overview]
Message-ID: <vpqlirhitvw.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1321349492-5653-1-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Tue, 15 Nov 2011 15:01:32 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Some of the fatal messages printed by revert and cherry-pick look ugly
> like the following:
>
> fatal: Could not open .git/sequencer/todo.: No such file or directory
>
> The culprit here is the die_errno() function that takes a custom error
> message string as an argument and appends ": <message from errno>"
> before printing it. So, we can fix the problem by not terminating the
> string argument to the function with a '.' (period). Fatal messages
> look nicer now:
>
> fatal: Could not open .git/sequencer/todo: No such file or directory
Sounds (obviously) good.
(I just misread the subject line at first, and understood that this was
a revert of an earlier commit, while this is actually a commit touching
the "revert" part of Git)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2011-11-15 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 9:31 [PATCH] revert: prettify fatal messages Ramkumar Ramachandra
2011-11-15 10:04 ` Matthieu Moy [this message]
2011-11-16 1:05 ` Junio C Hamano
2011-11-16 6:23 ` Ramkumar Ramachandra
2011-11-16 6:42 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqlirhitvw.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).