From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2 (v2)] reset: make the output more user-friendly.
Date: Mon, 17 Aug 2009 19:31:53 +0200 [thread overview]
Message-ID: <vpqljlipcs6.fsf@bauges.imag.fr> (raw)
In-Reply-To: <vpq7hxeu4un.fsf@bauges.imag.fr> (Matthieu Moy's message of "Sat\, 08 Aug 2009 09\:44\:48 +0200")
[ back from holiday ]
Any opinion/update on this? I don't think I got any reply ...
Thanks,
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>>
>>> cat > expect << EOF
>>> -file2: locally modified
>>> +Unstaged changes after reset:
>>> +M file2
>>
>> It simply feels backwards when plumbing output says something in human
>> language (e.g. "needs update") while Porcelain output spits out a cryptic
>> M or U. If the goal is human-readability and user-friendliness,
>
> The goal here is just consistency.
>
> And I do consider 'git diff --name-status' as porcelain.
>
>> shouldn't we rather say:
>>
>> Path with local modifications:
>> file2
>>
>> or something?
>
> Why not, but if we do, we should also remove this "M" from other
> places. It was already there in one error message given by 'git
> rebase' in a non-clean tree (and you just accepted a patch giving the
> same output for another one).
--
Matthieu
next prev parent reply other threads:[~2009-08-17 18:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 15:25 Message from git reset: confusing? Matthieu Moy
2009-08-05 17:21 ` Junio C Hamano
2009-08-05 17:42 ` Avery Pennarun
2009-08-05 18:07 ` John Tapsell
2009-08-05 18:25 ` Sverre Rabbelier
2009-08-06 9:42 ` Matthieu Moy
2009-08-06 19:21 ` Junio C Hamano
2009-08-07 20:24 ` [PATCH 1/2] Rename REFRESH_SAY_CHANGED to REFRESH_IN_PORCELAIN Matthieu Moy
2009-08-07 20:24 ` [PATCH 2/2 (v2)] reset: make the output more user-friendly Matthieu Moy
2009-08-07 21:20 ` Junio C Hamano
2009-08-08 7:44 ` Matthieu Moy
2009-08-17 17:31 ` Matthieu Moy [this message]
2009-08-17 19:50 ` Junio C Hamano
2009-08-21 8:57 ` [PATCH 1/2] Rename REFRESH_SAY_CHANGED to REFRESH_IN_PORCELAIN Matthieu Moy
2009-08-21 8:57 ` [PATCH 2/2 (v3)] reset: make the output more user-friendly Matthieu Moy
2009-08-22 5:44 ` Junio C Hamano
2009-08-22 7:52 ` Matthieu Moy
2009-08-23 2:33 ` Junio C Hamano
2009-08-23 10:42 ` Matthieu Moy
2009-08-23 11:45 ` Reece Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqljlipcs6.fsf@bauges.imag.fr \
--to=matthieu.moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).