From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>
Cc: git@vger.kernel.org,
Remi Galan <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH/RFC v2 5/5] send-email: refactor address list process
Date: Mon, 08 Jun 2015 18:21:38 +0200 [thread overview]
Message-ID: <vpqmw0a2mst.fsf@anie.imag.fr> (raw)
In-Reply-To: <1247043051.275297.1433780082550.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Remi Lespinet's message of "Mon, 8 Jun 2015 18:14:42 +0200 (CEST)")
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr> writes:
>>
>> > Simplify code by creating a function to transform list of email lists
>> > (comma separated, with aliases ...) into a simple list of valid email
>> > addresses.
>>
>> I would have found the series easier to read if this refactoring came
>> earlier (and then PATCH 2/5 would fix the bug as a positive side effect
>> of the refactoring). I think it's too late to change this, though.
>
> Why is it to late? I can still change it if necessary.
To me, the series is ready now, and I don't think re-rolling it would be
a good time investment. Plus, I spent time reviewing this series and
with my proposal I'd need to review a relatively different one.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-08 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 16:59 [PATCH/RFC v2 1/5] t9001-send-email: move script creation in a setup test Remi Lespinet
2015-06-06 16:59 ` [PATCH/RFC v2 2/5] send-email: allow aliases in patch header and command script outputs Remi Lespinet
2015-06-06 16:59 ` [PATCH/RFC v2 3/5] t9001-send-email: refactor header variable fields replacement Remi Lespinet
2015-06-06 16:59 ` [PATCH/RFC v2 4/5] send-email: allow multiple emails using --cc, --to and --bcc Remi Lespinet
2015-06-06 16:59 ` [PATCH/RFC v2 5/5] send-email: refactor address list process Remi Lespinet
2015-06-08 14:16 ` Matthieu Moy
2015-06-08 16:14 ` Remi Lespinet
2015-06-08 16:21 ` Matthieu Moy [this message]
2015-06-08 17:36 ` Remi Lespinet
2015-06-08 18:36 ` Junio C Hamano
2015-06-08 22:12 ` Remi Lespinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqmw0a2mst.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).