From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] string-list: Add a value to string_list initializer lists
Date: Tue, 03 Jun 2014 17:20:39 +0200 [thread overview]
Message-ID: <vpqmwduqat4.fsf@anie.imag.fr> (raw)
In-Reply-To: <1401786798-3729-1-git-send-email-tanayabh@gmail.com> (Tanay Abhra's message of "Tue, 3 Jun 2014 02:13:18 -0700")
Tanay Abhra <tanayabh@gmail.com> writes:
> diff --git a/Documentation/technical/api-string-list.txt b/Documentation/technical/api-string-list.txt
> index 20be348..f1add51 100644
> --- a/Documentation/technical/api-string-list.txt
> +++ b/Documentation/technical/api-string-list.txt
> @@ -200,3 +200,5 @@ Represents the list itself.
> You should not tamper with it.
> . Setting the `strdup_strings` member to 1 will strdup() the strings
> before adding them, see above.
> +. The `compare_strings_fn` member is used to specify a custom compare
> + function, otherwise `strcmp()` is used as the default function.
Is this change intentional? It seems good, but not really related to the
change described in the commit message.
In any case, this remark should not block patch inclusion, it's trivial
enough.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2014-06-03 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 9:13 [PATCH v2] string-list: Add a value to string_list initializer lists Tanay Abhra
2014-06-03 15:20 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqmwduqat4.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox