From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Benoit Person <benoit.person@gmail.com>
Cc: git@vger.kernel.org, Benoit Person <benoit.person@gmail.fr>
Subject: Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions
Date: Mon, 23 Sep 2013 19:58:47 +0200 [thread overview]
Message-ID: <vpqr4cf773c.fsf@anie.imag.fr> (raw)
In-Reply-To: <1379957175-8606-1-git-send-email-benoit.person@gmail.fr> (Benoit Person's message of "Mon, 23 Sep 2013 19:26:15 +0200")
Benoit Person <benoit.person@gmail.com> writes:
> The latest API renamed and moved the "continuing" information in the
> response, necessary to build the next query. The code failed to retrieve
> that information but still detected that it was in a "continuing
> query". As a result, it launched the same query over and over again.
Good, that's much cleaner.
> + if ($result->{'query-continue'}) { # For legacy APIs
> + $query->{rvstartid} = $result->{'query-continue'}->{revisions}->{rvstartid};
> + } elsif ($result->{continue}) { # For newer APIs
I'd rather have the comments say "# API version < X" and "# API version
>= X". Next time the API change, "new" Vs "old" will become meaningless.
(But that should not block the patch from inclusion)
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-09-23 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 17:26 [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions Benoit Person
2013-09-23 17:58 ` Matthieu Moy [this message]
2013-09-23 20:17 ` Eric Sunshine
2013-09-24 8:05 ` Benoit Person
2013-09-24 8:19 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqr4cf773c.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=benoit.person@gmail.com \
--cc=benoit.person@gmail.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).