From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Sidhant Sharma \[\:tk\]" <tigerkid001@gmail.com>,
git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v2] builtin/receive-pack.c: use parse_options API
Date: Wed, 02 Mar 2016 09:23:46 +0100 [thread overview]
Message-ID: <vpqsi09xp7x.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqq4mcp7t28.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Tue, 01 Mar 2016 14:05:19 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> "Sidhant Sharma [:tk]" <tigerkid001@gmail.com> writes:
>>
>>> Make receive-pack use the parse_options API,
>>> bringing it more in line with send-pack and push.
>>
>> Thanks. This version looks good to me.
>
> I'll queue this with your "Reviewed-by:" to 'pu', just as a
> Microproject reward ;-). Given that the program will never see an
> interactive use from a command line, however, I am not sure if it is
> worth actually merging it down thru 'next' to 'master'.
Git can certainly live without this patch and users won't see any
difference indeed. But the slight code reduction might be worth it:
builtin/receive-pack.c | 53 +++++++++++++++++++-------------------------------
1 file changed, 20 insertions(+), 33 deletions(-)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-03-02 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 15:36 [PATCH] builtin/receive-pack.c: use parse_options API Sidhant Sharma [:tk]
2016-03-01 17:22 ` Matthieu Moy
2016-03-01 17:48 ` Sidhant Sharma
2016-03-01 17:57 ` Matthieu Moy
2016-03-01 18:54 ` Eric Sunshine
2016-03-01 20:21 ` [PATCH v2] " Sidhant Sharma [:tk]
2016-03-01 20:31 ` Sidhant Sharma
2016-03-01 20:39 ` Matthieu Moy
2016-03-01 22:05 ` Junio C Hamano
2016-03-02 5:18 ` Sidhant Sharma
2016-03-02 8:51 ` Junio C Hamano
2016-03-02 8:23 ` Matthieu Moy [this message]
2016-03-02 9:53 ` Duy Nguyen
2016-03-02 13:53 ` Sidhant Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqsi09xp7x.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=tigerkid001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).