From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Ben Walton <bwalton@artsci.utoronto.ca>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Mark http-fetch without -a as deprecated
Date: Tue, 23 Aug 2011 09:02:02 +0200 [thread overview]
Message-ID: <vpqvcto391x.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1314060703-24265-1-git-send-email-bwalton@artsci.utoronto.ca> (Ben Walton's message of "Mon, 22 Aug 2011 20:51:43 -0400")
Ben Walton <bwalton@artsci.utoronto.ca> writes:
> + if (get_all == 0)
> + warning("http-fetch: use without -a is deprecated; -a will become the default in a future release");
Bad indentation. Git indents with tabs, not spaces. Also, you can break
the line to make both the error message and the source code fit on 80
characters.
No opinion on whether the deprecation is sensible, though. If it is, add
something in the documentation, not just in the code.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2011-08-23 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 0:51 [PATCH] Mark http-fetch without -a as deprecated Ben Walton
2011-08-23 7:02 ` Matthieu Moy [this message]
2011-08-23 13:05 ` Ben Walton
2011-08-24 0:29 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvcto391x.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).