From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jeff King <peff@peff.net>
Cc: Michal Vyskocil <mvyskocil@suse.cz>, git@vger.kernel.org
Subject: Re: [PATCH] show git tag output in pager
Date: Mon, 03 Oct 2011 14:57:09 +0200 [thread overview]
Message-ID: <vpqwrcmw7ve.fsf@bauges.imag.fr> (raw)
In-Reply-To: <20110930104241.GB24507@sigill.intra.peff.net> (Jeff King's message of "Fri, 30 Sep 2011 06:42:41 -0400")
Jeff King <peff@peff.net> writes:
> On Thu, Sep 29, 2011 at 11:37:49AM +0200, Michal Vyskocil wrote:
>
>> On Tue, Sep 27, 2011 at 04:19:39PM +0200, Matthieu Moy wrote:
>> > The commit message should explain why this is needed, and in particular
>> > why you prefer this to setting pager.tag in your ~/.gitconfig.
>>
>> Opps! I read a documentation, but I did not realize this works for all
>> commands and not only for them calling setup_pager(). Then sorry, no
>> change is needed.
>
> I don't think you want to set pager.tag. It will invoke the pager for
> all tag subcommands, including tag creation and deletion.
That's the kind of argument/discussion I was expecting in the commit
message.
> I think instead, you want some way for commands to say "OK, I'm in a
> subcommand that might or might not want a pager now".
Right.
I like the try_subcommand_pager idea. Ideally, there would also be a
nice mechanism to set defaults for subcommands, so that "git tag
<whatever>" does the right thing without configuration.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2011-10-03 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 13:42 [PATCH] show git tag output in pager Michal Vyskocil
2011-09-27 14:19 ` Matthieu Moy
2011-09-29 9:37 ` Michal Vyskocil
2011-09-30 10:42 ` Jeff King
2011-10-03 12:57 ` Matthieu Moy [this message]
2011-10-07 14:44 ` Jeff King
2011-10-07 14:48 ` Matthieu Moy
2011-10-07 16:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqwrcmw7ve.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=mvyskocil@suse.cz \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).