git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
	Jorge Juan Garcia Garcia 
	<Jorge-Juan.Garcia-Garcia@ensimag.imag.fr>,
	Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag.imag.fr>
Subject: Re: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default
Date: Tue, 11 Jun 2013 09:51:58 +0200	[thread overview]
Message-ID: <vpqy5ah84pt.fsf@anie.imag.fr> (raw)
In-Reply-To: <CALkWK0mQ9e1nR1jBgZKB6hgV+ptEXr225MchsVoM6514-KdqPg@mail.gmail.com> (Ramkumar Ramachandra's message of "Tue, 11 Jun 2013 13:00:45 +0530")

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> <y@ensimag.imag.fr> wrote:
>> [...]
>
> Good change.
>
>> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
>> index 9a07f15..958617a 100755
>> --- a/t/t7508-status.sh
>> +++ b/t/t7508-status.sh
>
> I expected one test.  Two, at most.  This is a bit overzealous. 

I actually had this discussion with Jorge (in real life). I first
thought this was too much, and I think we already removed one rendundant
test. But actually, this should be "two at least", since you really want
to test whether --[no-]branch takes precedence over status.branch or
not, in addition to testing status.branch alone.

The last two tests are less important, but they also test something (in
short: what happens when branch.status is set to something other than
"true"). So I think it makes sense to keep them.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2013-06-11  7:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51b5ede3.41a42a0a.02a1.3464SMTPIN_ADDED_BROKEN@mx.google.com>
2013-06-11  7:30 ` v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default Ramkumar Ramachandra
2013-06-11  7:51   ` Matthieu Moy [this message]
2013-06-10 15:13 v3 [PATCH 1/2] status: introduce status.short to enable --short " y
2013-06-10 15:13 ` v3 [PATCH 2/2] status:introduce status.branch to enable --branch " y
2013-06-10 15:13 ` y

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqy5ah84pt.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
    --cc=Mathieu.Lienard--Mayor@ensimag.imag.fr \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).