From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
git <git@vger.kernel.org>
Subject: Re: nd/setup
Date: Sun, 11 Apr 2010 19:57:06 +0200 [thread overview]
Message-ID: <w2mfcaeb9bf1004111057g58cefafdqc1cc30a8c9f82032@mail.gmail.com> (raw)
In-Reply-To: <20100408214233.GA32441@progeny.tock>
2010/4/8 Jonathan Nieder <jrnieder@gmail.com>:
> Jeff King wrote:
>> On Wed, Apr 07, 2010 at 05:48:02PM -0700, Junio C Hamano wrote:
>
>>> * nd/setup (2010-04-05) 43 commits
> [...]
>> Probably one or both
>> of us should look at it before applying it to next, but assuming it
>> passes a basic sanity check, I think the best thing will be to get it in
>> 'next' early so we can shake out any bugs during the next cycle.
>
> I don’t think it’s anywhere near master material yet.
No it's not. I spent a bit of time on it this morning. A few notes:
- My logic to restore repo state in run_builtin, patch "Guard
unallowed access..", is just broken, and will lead to many die()s (or
warning()s with the squash)
- "git -p init" will not work, pager problem again.
--
Duy
next prev parent reply other threads:[~2010-04-11 17:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 0:48 What's cooking in git.git (Apr 2010, #03; Wed, 07) Junio C Hamano
2010-04-08 6:05 ` Johannes Sixt
2010-04-08 6:33 ` Junio C Hamano
2010-04-08 9:01 ` Fredrik Kuivinen
2010-04-08 9:14 ` ***SPAM*** " Tor Arntsen
2010-04-08 9:16 ` Tor Arntsen
2010-04-08 7:38 ` Jeff King
2010-04-08 21:42 ` nd/setup Jonathan Nieder
2010-04-09 0:13 ` nd/setup Jeff King
2010-04-11 11:01 ` [PATCH] Take it easy on unallowed access to non-existent repository Nguyễn Thái Ngọc Duy
2010-04-11 15:45 ` Sverre Rabbelier
2010-04-11 17:49 ` Nguyen Thai Ngoc Duy
2010-04-11 17:52 ` Sverre Rabbelier
2010-04-11 17:57 ` Nguyen Thai Ngoc Duy
2010-04-09 5:46 ` nd/setup Nguyen Thai Ngoc Duy
2010-04-09 5:57 ` nd/setup Jonathan Nieder
2010-04-09 6:56 ` nd/setup Nguyen Thai Ngoc Duy
2010-04-11 17:57 ` Nguyen Thai Ngoc Duy [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-04-02 8:40 What's cooking in git.git (Apr 2010, #01; Fri, 02) Junio C Hamano
2010-04-02 11:23 ` Nguyen Thai Ngoc Duy
2010-04-03 5:00 ` nd/setup Jonathan Nieder
2010-04-03 14:39 ` nd/setup Nguyen Thai Ngoc Duy
2010-04-04 18:41 ` nd/setup Nguyen Thai Ngoc Duy
2010-04-04 21:42 ` nd/setup Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w2mfcaeb9bf1004111057g58cefafdqc1cc30a8c9f82032@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).