From: Tay Ray Chuan <rctay89@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] branch: say "Reset to" in reflog entries for 'git branch -f' operations
Date: Fri, 9 Apr 2010 20:18:54 +0800 [thread overview]
Message-ID: <w2nbe6fef0d1004090518hee66e33esd93e767580837b55@mail.gmail.com> (raw)
In-Reply-To: <4BBF159A.1000206@drmicha.warpmail.net>
Hi,
On Fri, Apr 9, 2010 at 7:55 PM, Michael J Gruber
<git@drmicha.warpmail.net> wrote:
> I know the patch is not large, but one really has to read it after
> wondering: Huh? What is branch -f doing now before the patch? To me it
> sounded as if it didn't write to the reflog at all. So, how about
>
> elsewhere, it would make sense to say "Reset to" here as well rather
> than "Rest from".
Sounds good.
> But I also have a functional question: Is "start_from" really the ref
> *to* which the branch is reset? I hope reset does it right.
(I think you mean "start_name" instead of "start_from".)
Well, "start_name" determines where the branch/ref points to. I don't
think any branch can "start", except that it can diverge.
But that's outside the scope of this patch.
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-04-09 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 7:45 [PATCH] branch: say "Reset to" in reflog entries for 'git branch -f' operations Tay Ray Chuan
2010-04-09 11:55 ` Michael J Gruber
2010-04-09 12:03 ` Matthieu Moy
2010-04-09 12:20 ` Johannes Sixt
2010-04-09 12:18 ` Tay Ray Chuan [this message]
2010-04-09 12:38 ` [PATCH v2] " Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w2nbe6fef0d1004090518hee66e33esd93e767580837b55@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).