From: Eli Collins <eli@cloudera.com>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] diff: add a 'path' meta header for non-renames and non-copies
Date: Wed, 5 May 2010 14:14:42 -0700 [thread overview]
Message-ID: <w2ndfe484f01005051414p294820f8jbf974b0cde20236d@mail.gmail.com> (raw)
In-Reply-To: <AANLkTilsk7Hh0oN72SfOlRK92qQhjVa-rNYUtVHocEj0@mail.gmail.com>
Ditto. I frequently generate patches for other systems (primarily
svn) and they require diffs w/o perfixes. Seemed like there should be
a way to enable this option in gitconfig so users don't need to type
--no-prefix w every diff invocation or use an alias (aliasing diff to
diff --no-prefix in gitconfig doesn't work and wouldn't be a good idea
anyway).
Thanks,
Eli
On Tue, May 4, 2010 at 12:30 PM, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> On Tue, May 4, 2010 at 03:34, Junio C Hamano <gitster@pobox.com> wrote:
>> Bert Wesarg <bert.wesarg@googlemail.com> writes:
>>
>>> ... do you have any other
>>> thoughts on adding a <path> extended header for non-renames and
>>> non-copies?
>>
>> Other than "Why do we even need it?", no. We actually have been careful
>> when designing the output format to make sure that necessary information
>> appears.
>>
>> See also this thread:
>>
>> http://thread.gmane.org/gmane.comp.version-control.git/3990/focus=4002
>>
>> I wasn't too opposed to having a separate "Index: " line (or Anton's
>> "name") like CVS does, but the conclusion of the thread was that it is not
>> necessary.
>>
>
> Thanks for the pointer. The discussion revolves around technical
> arguments and the conclusion that this extra information is not
> necessary is reasonable. My intention for this information comes only
> from the usability and convenience side: I want a path without any
> prefix which I can select in the terminal and use this to open the
> file. Thats why it is only an option for the UI interface.
>
> Bert
>
prev parent reply other threads:[~2010-05-05 21:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 2:03 [PATCH] diff: add configuration option for disabling diff prefixes Eli Collins
2010-05-03 6:27 ` [PATCH] diff: add a 'path' meta header for non-renames and non-copies Bert Wesarg
2010-05-03 7:30 ` Junio C Hamano
2010-05-03 7:37 ` Bert Wesarg
2010-05-03 16:29 ` Junio C Hamano
2010-05-03 22:55 ` Bert Wesarg
2010-05-04 1:34 ` Junio C Hamano
2010-05-04 19:30 ` Bert Wesarg
2010-05-05 21:14 ` Eli Collins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w2ndfe484f01005051414p294820f8jbf974b0cde20236d@mail.gmail.com \
--to=eli@cloudera.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).