git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sylvain Rabot <sylvain@abstraction.fr>
To: Wincent Colaiuta <win@wincent.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>, git <git@vger.kernel.org>
Subject: Re: Add warning when there are changes in the index and using -a with  git commit
Date: Thu, 22 Apr 2010 00:38:18 +0200	[thread overview]
Message-ID: <w2r7fce93be1004211538pe406dfebs79e1f4673e521988@mail.gmail.com> (raw)
In-Reply-To: <0CCBCCA0-8378-42A8-A925-F60AA09949DC@wincent.com>

On Wed, Apr 21, 2010 at 23:38, Wincent Colaiuta <win@wincent.com> wrote:

> Without even really meaning to, I ended up training myself to only commit what's staged in the index, because early on I acquired the habit of always reviewing every single changed hunk by using "git add --patch" (in fact I use it so often that I've created an alias of "git patch" for it). There's no telling how many times this kind of last-minute hunk-by-hunk reviewing has saved me from committing bad code.

Well, the thing is I do that to but instinctively, 3 seconds after, I
do my git commit -as -m "blah", making useless the time I spend
staging hunks with git add -p

-- 
Sylvain

      reply	other threads:[~2010-04-21 22:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 20:20 Add warning when there are changes in the index and using -a with git commit Sylvain Rabot
2010-04-21 21:21 ` Sverre Rabbelier
2010-04-21 21:31   ` Eli Barzilay
2010-04-21 21:38   ` Wincent Colaiuta
2010-04-21 22:38     ` Sylvain Rabot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w2r7fce93be1004211538pe406dfebs79e1f4673e521988@mail.gmail.com \
    --to=sylvain@abstraction.fr \
    --cc=git@vger.kernel.org \
    --cc=srabbelier@gmail.com \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).