From: Jon Seymour <jon.seymour@gmail.com>
To: gitzilla@gmail.com
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Alexander Gladysh <agladysh@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH/RFC] gitk: refresh index before checking for local changes
Date: Thu, 8 Apr 2010 02:36:13 +1200 [thread overview]
Message-ID: <x2w2cfc40321004070736q7ab306b7i6220ffd58f724cec@mail.gmail.com> (raw)
In-Reply-To: <4BBBEC43.5000100@gmail.com>
On Wed, Apr 7, 2010 at 2:21 PM, A Large Angry SCM <gitzilla@gmail.com> wrote:
>
> NAK - gitk should not modify a repository and/or working dir unless
> _explicitly_ prompted to by the user.
>
> If you want a new _non-default_ option setting for gitk, that fine also.
gitk and git gui currently behave differently in this regard.
git gui updates the indexes view of the working tree on start, gitk does not.
gitk's current behaviour is somewhat mysterious to the uninitiated -
user: "what? I have local changes?"
tool: "relax dear user what you see is dirty laundry. if you want to
see the actual state, start git gui then come back to me and refresh
me when you are done"
gitk is effectively lying to the user about the state of their working
tree. git gui does not.
Needless to say, I support this change.
jon.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-04-07 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 22:57 gitk pays too much attention to file timestamps Alexander Gladysh
2010-04-06 23:15 ` Markus Heidelberg
2010-04-06 23:36 ` Jonathan Nieder
2010-04-06 23:47 ` Alexander Gladysh
2010-04-07 0:43 ` [PATCH/RFC] gitk: refresh index before checking for local changes Jonathan Nieder
2010-04-07 1:07 ` Alexander Gladysh
2010-04-07 1:16 ` Jonathan Nieder
2010-04-07 2:21 ` A Large Angry SCM
2010-04-07 2:57 ` Jonathan Nieder
2010-04-07 5:47 ` Junio C Hamano
2010-04-07 11:21 ` A Large Angry SCM
2010-04-07 16:48 ` Avery Pennarun
2010-04-07 14:36 ` Jon Seymour [this message]
2010-04-06 23:58 ` gitk pays too much attention to file timestamps Avery Pennarun
2010-04-07 1:01 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x2w2cfc40321004070736q7ab306b7i6220ffd58f724cec@mail.gmail.com \
--to=jon.seymour@gmail.com \
--cc=agladysh@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitzilla@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).