git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Josef Bacik <josef@redhat.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFE] allow git bisect to figure out in which revision a bug was fixed
Date: Tue, 21 Jul 2009 16:34:58 -0400	[thread overview]
Message-ID: <x49k521ojv1.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20090721202848.GA3453@localhost.localdomain> (Josef Bacik's message of "Tue, 21 Jul 2009 16:28:48 -0400")

Josef Bacik <josef@redhat.com> writes:

> On Tue, Jul 21, 2009 at 01:24:46PM -0700, Junio C Hamano wrote:
>> Jeff Moyer <jmoyer@redhat.com> writes:
>> 
>> > As a distro kernel grunt, I sometimes find myself in the situation of
>> > having to track down the commit that fixed a given problem so that I can
>> > backport it to an older kernel.  Sometimes I'm smart enough to figure it
>> > out myself, other times I'm not.  ;-)  It would be helpful if git bisect
>> > could help figure out in what commit a bug was fixed as opposed to
>> > introduced.  Is there any interest in implementing such a feature?
>> 
>> Doesn't that already exist?
>> 
>> You are hunting for an existence of the bug, so any commit that is buggy
>> (with respect to the bug you are interested in) is *GOOD*.  The tip of the
>> upstream is *BAD* in that it does not have your favourite bug anymore.
>> 
>> You bisect that history down, and will find the first *BAD* commit.
>> 
>> Now, why is that commit the procedure finds is *BAD*, again?  Yup, because
>> it does not have your favourite bug anymore.  And why is that so?
>> 
>> Because the commit fixed that bug.
>
> Sure, but as one who has used this procedure several times before, it is very
> error prone, on my side because I'm a big goober.  I have a tendancy to get my
> wires crossed and get dumped out at a commit that doesnt make sense (my latest
> attempt put me out at a merge commit).  Sure its my fault for not being able to
> keep it straight, theres no arguing that, it still would be nice for there to be
> a way to remove as much human error from the process as possible.  Thanks,

And now that I've done the research I should have done before posting, I
see that this feature has been requested at least 2 other times.  I can
get by the way things stand, for sure, but it sounds like there's
interest in making things a bit more user friendly.

Thanks for your time.

-Jeff

  reply	other threads:[~2009-07-21 20:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 20:16 [RFE] allow git bisect to figure out in which revision a bug was fixed Jeff Moyer
2009-07-21 20:24 ` Junio C Hamano
2009-07-21 20:28   ` Josef Bacik
2009-07-21 20:34     ` Jeff Moyer [this message]
2009-07-21 20:40     ` Junio C Hamano
2009-07-21 20:45       ` Jeff Moyer
2009-07-22  0:35       ` Nicolas Pitre
2009-07-22  1:08         ` Junio C Hamano
2009-07-22  1:20           ` Nicolas Pitre
2009-07-22  2:41             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49k521ojv1.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=josef@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).