From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Vsevolod Myalitsin <ub4nal@mail.ru>,
ben.knoble@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] advice: use global config for default branch name
Date: Thu, 10 Sep 2026 05:18:21 -0700 [thread overview]
Message-ID: <xmqq1pb147w2.fsf@gitster.g> (raw)
In-Reply-To: <20260910043356.GB241223@coredump.intra.peff.net> (Jeff King's message of "Thu, 10 Sep 2026 00:33:56 -0400")
Jeff King <peff@peff.net> writes:
> But I think the bigger question remains: if we did this, would people
> find the extra lines giving the turn-off instructions ugly/overwhelming?
> I'm not sure.
Well, if they find them unnecessary then they would want to turn it
off and the instruction is already there ;-)
More seriously, if an advice item is found as such, then the item
either must (1) be beneficial enough to be always shown, or (2) be
so rarely shown that the turn-off instruction is unneeded. It would
inherently be case-by-case basis but I do think we would converge
between unconditional advise() calls or advise_if_enabled() calls.
next prev parent reply other threads:[~2026-09-10 12:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:56 [PATCH] advice: use global config for default branch name Vsevolod Myalitsin
2026-09-08 13:35 ` Ben Knoble
2026-09-08 18:56 ` Vsevolod Myalitsin
2026-09-08 14:59 ` Ben Knoble
2026-09-08 19:56 ` R4NC
2026-09-08 16:24 ` D. Ben Knoble
2026-09-08 16:31 ` Junio C Hamano
2026-09-08 21:38 ` Vsevolod Myalitsin
2026-09-08 18:57 ` Junio C Hamano
2026-09-09 6:49 ` R4NC
2026-09-09 15:54 ` Jeff King
2026-09-09 18:51 ` Junio C Hamano
2026-09-09 19:51 ` Jeff King
2026-09-10 4:23 ` Junio C Hamano
2026-09-10 4:33 ` Jeff King
2026-09-10 12:18 ` Junio C Hamano [this message]
2026-09-10 16:31 ` Jeff King
2026-09-10 4:28 ` Junio C Hamano
2027-08-29 0:59 ` Vsevolod Myalitsin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pb147w2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ub4nal@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox