Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: graysongordon-gl <graysongordon1@gmail.com>
Cc: git@vger.kernel.org,  peff@peff.net,  avarab@gmail.com,  ps@pks.im
Subject: Re: [PATCH v3] http: add http.sslVerifyStatus to check stapled OCSP responses
Date: Wed, 12 Aug 2026 14:34:03 -0700	[thread overview]
Message-ID: <xmqq1pc3vx9w.fsf@gitster.g> (raw)
In-Reply-To: <20260812182509.67358-1-ggordon@gitlab.com> (graysongordon-gl's message of "Wed, 12 Aug 2026 14:25:09 -0400")

graysongordon-gl <graysongordon1@gmail.com> writes:

> v3: rename the test from t5567 to t5568. t5567 is taken on 'seen' by
>     mm/lib-httpd-cgi-safe. t5568 is free on master, next, seen, jch and
>     maint as of b9720e4723, and sits next to the other http tests. No
>     other change.

I thought I first asked whether we need a new script before
suggesting moving it out of the way because 't5567' was already
taken.  It is much better not to waste a scarce, shared resource
such as a test number, and doing so avoids breaking the build if we
are not careful.

If we really need to add a new script, you would need to squash in
at least a patch like this to avoid breaking Meson-based builds.


 t/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git i/t/meson.build w/t/meson.build
index 3219264fe7..3d68f67680 100644
--- i/t/meson.build
+++ w/t/meson.build
@@ -707,6 +707,7 @@ integration_tests = [
   't5564-http-proxy.sh',
   't5565-push-multiple.sh',
   't5566-push-group.sh',
+  't5568-http-verify-status.sh',
   't5570-git-daemon.sh',
   't5571-pre-push-hook.sh',
   't5572-pull-submodule.sh',

      reply	other threads:[~2026-08-12 21:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 17:02 [PATCH] http: add http.sslVerifyStatus to check stapled OCSP responses graysongordon-gl
2026-08-11 19:28 ` Junio C Hamano
2026-08-11 20:44 ` [PATCH v2] " graysongordon-gl
2026-08-12  6:25   ` Patrick Steinhardt
2026-08-12 15:53     ` Grayson Gordon
2026-08-12 14:17   ` Junio C Hamano
2026-08-12 18:25     ` [PATCH v3] " graysongordon-gl
2026-08-12 21:34       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1pc3vx9w.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=graysongordon1@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox