From: Junio C Hamano <gitster@pobox.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH 1/6] SubmittingPatches: encourage trailer use for substantial help
Date: Thu, 11 Jun 2026 09:44:57 -0700 [thread overview]
Message-ID: <xmqq1pedowl2.fsf@gitster.g> (raw)
In-Reply-To: <encourage_substantial.8f4@msgid.xyz> (kristofferhaugsbakk@fastmail.com's message of "Thu, 11 Jun 2026 00:22:44 +0200")
kristofferhaugsbakk@fastmail.com writes:
> Let’s replace “If you like” with outright encouragment in this section
"encouragement"?
> At the same, it is important to temper this recommendation to a sign-
> ificant enough contribution; in my experience beginners can be eager
"At the same time"?
It is a bit unusual to see a long word split at the end of a line
to line-wrap in our documentation and commit log messages.
> ---
> Documentation/SubmittingPatches | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
The patch text itself looks great. Thanks.
next prev parent reply other threads:[~2026-06-11 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 22:22 [PATCH 0/6] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 1/6] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-11 16:44 ` Junio C Hamano [this message]
2026-06-10 22:22 ` [PATCH 2/6] SubmittingPatches: discuss non-ident trailers kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 3/6] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-11 16:46 ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer kristofferhaugsbakk
2026-06-11 16:52 ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 5/6] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 6/6] SubmittingPatches: note that trailer order matters kristofferhaugsbakk
2026-06-10 22:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pedowl2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox