public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
	 git@vger.kernel.org,  Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] editorconfig: fix style not applying to subdirs anymore
Date: Wed, 11 Mar 2026 10:32:52 -0700	[thread overview]
Message-ID: <xmqq1phqqnjv.fsf@gitster.g> (raw)
In-Reply-To: <1eb3b78c-5833-4fa9-83f6-237d4a3e78d3@gmail.com> (Phillip Wood's message of "Wed, 11 Mar 2026 14:16:53 +0000")

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 11/03/2026 07:09, Patrick Steinhardt wrote:
>...
>>    If the glob contains a path separator (a / not inside square
>>    brackets), then the glob is relative to the directory level of the
>>    particular .editorconfig file itself. Otherwise the pattern may also
>>    match at any level below the .editorconfig level.
>> 
>> What's interesting is that the _whole_ expression is considered to be
>> the glob.
>
> Ouch, I'd missed that, thanks for fixing it
> ...
>>    [{{,**/}*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,{,**/}Makefile,templates/hooks/*.sample}]
>>    indent_style = tab
>>    tab_width = 8
>> 
>> This starts to become somewhat hard to read, so the duplication feels
>> like the better tradeoff.
>
> Agreed

Thanks, both.

      reply	other threads:[~2026-03-11 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  7:09 [PATCH] editorconfig: fix style not applying to subdirs anymore Patrick Steinhardt
2026-03-11 14:16 ` Phillip Wood
2026-03-11 17:32   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1phqqnjv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox