public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Alan Braithwaite via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, ps@pks.im, christian.couder@gmail.com,
	me@ttaylorr.com, Jeff King <peff@peff.net>,
	Alan Braithwaite <alan@braithwaite.dev>
Subject: Re: [PATCH v3] clone: add clone.<url>.defaultObjectFilter config
Date: Fri, 06 Mar 2026 11:33:10 -0800	[thread overview]
Message-ID: <xmqq1phw21op.fsf@gitster.g> (raw)
In-Reply-To: <aaqu44_sDJYcftWd@fruit.crustytoothpaste.net> (brian m. carlson's message of "Fri, 6 Mar 2026 10:39:31 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> We've historically not implemented default filtering for clones because
> it makes it hard to reason about the behaviour of the clone command.
> For instance, if I have a script that clones a repository, it almost
> certainly expects a full clone unless it requested something else.
> ...
> We've traditionally placed this kind of customizable configuration into
> `scalar` instead, which is designed to be configurable and set options
> for large repositories that would want to control clone and fetch
> options.

Hmph, my knee-jerk reaction to the early part of your message was
"oh, but isn't clone a Porcelain (admittedly without corresponding
plumbing) whose defaults and end-user experiences are meant to be
updated from time to time to help users?" but I didn't realize that
we have another class, which is "scalar", these days that we can add
these settings to.  I do not have objections to add something to
"scalar", but I personally feel that the configuration for clone is
such a bad thing to have.

Do we have a way to defeat the configured filter to say "no
filtering, we want everything" from the command line?  If not, that
needs to be addressed, if we were to add this configuration.

Thanks.


  reply	other threads:[~2026-03-06 19:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01 16:44 [PATCH] fetch, clone: add fetch.blobSizeLimit config Alan Braithwaite via GitGitGadget
2026-03-02 11:53 ` Patrick Steinhardt
2026-03-02 18:28   ` Jeff King
2026-03-02 18:57   ` Junio C Hamano
2026-03-02 21:36     ` Alan Braithwaite
2026-03-03  6:30       ` Patrick Steinhardt
2026-03-03 14:00         ` Alan Braithwaite
2026-03-03 15:08           ` Patrick Steinhardt
2026-03-03 17:58             ` Junio C Hamano
2026-03-04  5:07               ` Patrick Steinhardt
2026-03-03 17:05         ` Junio C Hamano
2026-03-03 14:34       ` Jeff King
2026-03-05  0:57 ` [PATCH v2] clone: add clone.<url>.defaultObjectFilter config Alan Braithwaite via GitGitGadget
2026-03-05 19:01   ` Junio C Hamano
2026-03-05 23:11     ` Alan Braithwaite
2026-03-06  6:55   ` [PATCH v3] " Alan Braithwaite via GitGitGadget
2026-03-06 10:39     ` brian m. carlson
2026-03-06 19:33       ` Junio C Hamano [this message]
2026-03-06 21:50         ` Alan Braithwaite
2026-03-06 21:47     ` [PATCH v4] " Alan Braithwaite via GitGitGadget
2026-03-06 22:18       ` Junio C Hamano
2026-03-07  1:04         ` Alan Braithwaite
2026-03-07  1:33       ` [PATCH v5] " Alan Braithwaite via GitGitGadget
2026-03-11  7:44         ` Patrick Steinhardt
2026-03-15  1:33           ` Alan Braithwaite
2026-03-15  5:37         ` [PATCH v6] " Alan Braithwaite via GitGitGadget
2026-03-15 21:32           ` Junio C Hamano
2026-03-16  7:47           ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1phw21op.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=alan@braithwaite.dev \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox