public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com>
Cc: git@vger.kernel.org,  Karthik Nayak <karthik.188@gmail.com>,
	 Justin Tobler <jltobler@gmail.com>,
	 Ayush Chandekar <ayu.chandekar@gmail.com>,
	Siddharth Asthana <siddharthasthana31@gmail.com>,
	lucasseikioshiro@gmail.com
Subject: Re: [PATCH GSoC] repo: Remove unnecessary variable shadow
Date: Fri, 27 Feb 2026 11:11:21 -0800	[thread overview]
Message-ID: <xmqq1pi6q9wm.fsf@gitster.g> (raw)
In-Reply-To: <CA+rGoLeppg4Xaoqg6+SZ=ET=ze6rXUbmjLm5UvmitmRGm9u6ag@mail.gmail.com> (JAYATHEERTH K.'s message of "Fri, 27 Feb 2026 22:37:45 +0530")

JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com> writes:

> I got a review on this patch,
> if no one has an issue I wanted to remind it for the next cycle.

Thanks.

An easier way to ping is to resubmit exactly the same patch, with
reviewed-by: or acked-by: trailer crediting the reviewer.  We have
2000+ messages in 4 weeks, so "I got a review on this patch" without
a pointer is much less useful to verify what feedback came to the
thread from whom.  FYI here are from the headers of the message I am
responding to.

    References: <20260223135248.127935-1-jayatheerthkulkarni2005@gmail.com>
    Message-ID: <CA+rGoLeppg4Xaoqg6+SZ=ET=ze6rXUbmjLm5UvmitmRGm9u6ag@mail.gmail.com>

The reference points at the patch itself, and just like Git commits
do not have pointers to their children, the original patch message
has no links to reviews on it X-<.

I'll commit this with the following change now.

Thanks.

1:  006c49ee01 ! 1:  a66c8c7f91 repo: Remove unnecessary variable shadow
    @@ Metadata
     Author: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
     
      ## Commit message ##
    -    repo: Remove unnecessary variable shadow
    +    repo: remove unnecessary variable shadow
     
         Avoid redeclaring `entry` inside the conditional block, removing
         unnecessary variable shadowing and improving code clarity without
         changing behavior.
     
         Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
    +    Acked-by: Justin Tobler <jltobler@gmail.com>
         Signed-off-by: Junio C Hamano <gitster@pobox.com>
     
      ## builtin/repo.c ##



      reply	other threads:[~2026-02-27 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 13:52 [PATCH GSoC] repo: Remove unnecessary variable shadow K Jayatheerth
2026-02-23 15:32 ` Justin Tobler
2026-02-27 17:07 ` JAYATHEERTH K
2026-02-27 19:11   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1pi6q9wm.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ayu.chandekar@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jayatheerthkulkarni2005@gmail.com \
    --cc=jltobler@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=lucasseikioshiro@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox