From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "D. Ben Knoble" <ben.knoble+github@gmail.com>,
git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 1/5] parseopt: fix :(optional) at command line to only ignore missing files
Date: Tue, 04 Nov 2025 09:24:57 -0800 [thread overview]
Message-ID: <xmqq1pmdr9qu.fsf@gitster.g> (raw)
In-Reply-To: <ec8d1764-649d-4edf-b0ae-a19ead5f6f9a@gmail.com> (Phillip Wood's message of "Tue, 4 Nov 2025 16:19:31 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> Hi Ben
>
> These all look good to me though I agree with Junio's comments on patch
> 3. It would be nice to get at least the fist patch merged in time for
> 2.52.0.
Yup, let me do exactly that ;-)
Thanks, both.
next prev parent reply other threads:[~2025-11-04 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 16:17 [PATCH 0/5] Fixes for :(optional) path code D. Ben Knoble
2025-11-02 16:17 ` [PATCH 1/5] parseopt: fix :(optional) at command line to only ignore missing files D. Ben Knoble
2025-11-04 16:19 ` Phillip Wood
2025-11-04 17:24 ` Junio C Hamano [this message]
2025-11-04 17:34 ` Junio C Hamano
2025-11-04 18:24 ` D. Ben Knoble
2025-11-05 16:35 ` Phillip Wood
2025-11-06 17:47 ` Junio C Hamano
2025-11-02 16:17 ` [PATCH 2/5] doc: clarify command equivalence comment D. Ben Knoble
2025-11-02 16:17 ` [PATCH 3/5] parseopt: use boolean type for a simple flag D. Ben Knoble
2025-11-03 5:19 ` Junio C Hamano
2025-11-04 16:21 ` Phillip Wood
2025-11-04 18:22 ` D. Ben Knoble
2025-11-02 16:17 ` [PATCH 4/5] config: " D. Ben Knoble
2025-11-02 16:17 ` [PATCH 5/5] parseopt: restore const qualifier to parsed filename D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pmdr9qu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble+github@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).