From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] t0450: add allowlist for builtins with missing .adoc
Date: Wed, 03 Sep 2025 11:46:17 -0700 [thread overview]
Message-ID: <xmqq1ponfk7a.fsf@gitster.g> (raw)
In-Reply-To: <87bjnrg4ky.fsf@iotcl.com> (Toon Claes's message of "Wed, 03 Sep 2025 13:26:05 +0200")
Toon Claes <toon@iotcl.com> writes:
> --text follows this line--
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Toon, did you have a chance to take a look at Patrick's update? Can
>> we move forward by squashing it into your [2/2]?
>
> Hi Junio,
>
> Yes, I've reviewed the changes, and they look good to me. I like the
> code more than the /clever/ approach I was attempting. My code succeeded
> on my machine, but it didn't on CI (sorry, I only saw that too late, I
> was rushing into my time off).
>
> Thanks both!
OK, then let me squash that into the base patch and mark the topic
for 'next'.
Thanks.
prev parent reply other threads:[~2025-09-03 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 7:30 [PATCH] t0450: fix test for out-of-tree builds Toon Claes
2025-08-04 7:56 ` Patrick Steinhardt
2025-08-05 12:11 ` Toon Claes
2025-08-08 9:59 ` [PATCH v2 0/2] Harden test t0450-txt-doc-vs-help Toon Claes
2025-08-08 9:59 ` [PATCH v2 1/2] t0450: fix test for out-of-tree builds Toon Claes
2025-08-08 9:59 ` [PATCH v2 2/2] t0450: add allowlist for builtins with missing .adoc Toon Claes
2025-08-08 22:07 ` Junio C Hamano
2025-08-12 12:52 ` Patrick Steinhardt
2025-08-28 23:12 ` Junio C Hamano
2025-09-02 20:57 ` Junio C Hamano
2025-09-03 11:26 ` Toon Claes
2025-09-03 18:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1ponfk7a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).