From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Hoyoung Lee <lhywkd22@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v4 1/1] test-delta: simplify delta helper with strbuf and better cleanup
Date: Fri, 25 Jul 2025 07:42:33 -0700 [thread overview]
Message-ID: <xmqq1pq45o2u.fsf@gitster.g> (raw)
In-Reply-To: <20250725111530.GA3015021@coredump.intra.peff.net> (Jeff King's message of "Fri, 25 Jul 2025 07:15:30 -0400")
Jeff King <peff@peff.net> writes:
> On Thu, Jul 24, 2025 at 11:09:55AM -0700, Junio C Hamano wrote:
>
>> OK. Except for the whitespace breakage, I didn't spot anything
>> glaringly wrong in the patch. Looking good.
>
> Hmm. This looks like just a squash of the 3-patch series I sent earlier?
I think I have your variant in my tree, and the results from both
variants do match.
prev parent reply other threads:[~2025-07-25 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 9:33 [PATCH v4 1/1] test-delta: simplify delta helper with strbuf and better cleanup Hoyoung Lee
2025-07-24 18:09 ` Junio C Hamano
2025-07-25 11:15 ` Jeff King
2025-07-25 11:16 ` Jeff King
2025-07-25 14:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pq45o2u.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lhywkd22@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).