From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Git Mailing List <git@vger.kernel.org>, Moumita <dhar61595@gmail.com>
Subject: Re: What's cooking in git.git (May 2025, #03; Wed, 7)
Date: Thu, 08 May 2025 06:28:43 -0700 [thread overview]
Message-ID: <xmqq1psz9qpg.fsf@gitster.g> (raw)
In-Reply-To: <d80dd1db-de81-4e5e-9d82-70794783780c@kdbg.org> (Johannes Sixt's message of "Thu, 8 May 2025 08:27:30 +0200")
Johannes Sixt <j6t@kdbg.org> writes:
> Am 08.05.25 um 03:26 schrieb Junio C Hamano:
>> * md/userdiff-bash-shell-function (2025-04-01) 1 commit
>> - userdiff: extend Bash pattern to cover more shell function forms
>>
>> The userdiff pattern for shell scripts has been updated to cope
>> with more bash-isms.
>>
>> Comments?
>> source: <20250330134018.9662-2-dhar61595@gmail.com>
>
> This round has room for improvement. I posted a review yesterday:
> https://lore.kernel.org/git/9d548d94-eed8-434a-a9ef-67df694c5c79@kdbg.org/
Yeah, I indeed saw your thoughtful review. Thanks for pointing this out.
prev parent reply other threads:[~2025-05-08 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 1:26 What's cooking in git.git (May 2025, #03; Wed, 7) Junio C Hamano
2025-05-08 6:27 ` Johannes Sixt
2025-05-08 13:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1psz9qpg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dhar61595@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).