From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] Makefile: remove accidental recipe prefix in conditional
Date: Thu, 13 Feb 2025 13:17:35 -0800 [thread overview]
Message-ID: <xmqq1pw1o87k.fsf@gitster.g> (raw)
In-Reply-To: <a79e9e9f50410721d85747b03559d55be98bca20.1739478347.git.me@ttaylorr.com> (Taylor Blau's message of "Thu, 13 Feb 2025 15:25:50 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> Back in 728b9ac0c3 (Makefile(s): avoid recipe prefix in conditional
> statements, 2024-04-08), we prepared our Makefiles for a forthcoming
> change in upstream Make that would ban the recipe prefix within a
> conditional statement by replacing tabs (the prefix) with eight spaces.
>
> In b9d6f64393 (compat/zlib: allow use of zlib-ng as backend,
> 2025-01-28), a handful of recipe prefix characters were introduced in a
> conditional statement ('ifdef ZLIB_NG'), causing 'make' to fail on my
> system, which uses GNU Make 4.4.90.
Yikes. Thanks for fixing it so quickly.
> Remove the recipe prefix characters by replacing them with the same
> script as is mentioned in 728b9ac0c3.
>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
> Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 90c9662ad3..5b98a9d12f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1703,16 +1703,16 @@ IMAP_SEND_LDFLAGS += $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
>
> ifdef ZLIB_NG
> BASIC_CFLAGS += -DHAVE_ZLIB_NG
> - ifdef ZLIB_NG_PATH
> + ifdef ZLIB_NG_PATH
> BASIC_CFLAGS += -I$(ZLIB_NG_PATH)/include
> EXTLIBS += $(call libpath_template,$(ZLIB_NG_PATH)/$(lib))
> - endif
> + endif
> EXTLIBS += -lz-ng
> else
> - ifdef ZLIB_PATH
> + ifdef ZLIB_PATH
> BASIC_CFLAGS += -I$(ZLIB_PATH)/include
> EXTLIBS += $(call libpath_template,$(ZLIB_PATH)/$(lib))
> - endif
> + endif
> EXTLIBS += -lz
> endif
>
>
> base-commit: e2067b49ecaef9b7f51a17ce251f9207f72ef52d
next prev parent reply other threads:[~2025-02-13 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 20:25 [PATCH] Makefile: remove accidental recipe prefix in conditional Taylor Blau
2025-02-13 21:17 ` Junio C Hamano [this message]
2025-02-14 4:55 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pw1o87k.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox