From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Scott Chacon <schacon@gmail.com>,
Scott Chacon via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Yongmin <yewon@revi.email>
Subject: Re: [PATCH v2] help: interpret boolean string values for help.autocorrect
Date: Fri, 10 Jan 2025 07:02:16 -0800 [thread overview]
Message-ID: <xmqq1pxaaf0n.fsf@gitster.g> (raw)
In-Reply-To: <20250110121100.GE1014503@coredump.intra.peff.net> (Jeff King's message of "Fri, 10 Jan 2025 07:11:00 -0500")
Jeff King <peff@peff.net> writes:
> It's not corrupted; that syntax is allowed for boolean variables[1]. The
> "bad config line" is due to the early "return config_error_nonbool(var)"
> quoted above. It is passing the error back to the general config code,
> which then just prints the "bad config" line.
>
> I think what Junio is saying is that if we are going to turn this into
> an option which accepts bool values, it should accept this special
> syntax, too. And that first "if (!value)" has to either go away (and get
> replace by a maybe_bool() call, as mentioned earlier) or has to set
> AUTOCORRECT_IMMEDIATELY itself.
Exactly.
Thanks for filling the blank in for me while I was away from the
keyboard ;-)
next prev parent reply other threads:[~2025-01-10 15:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 19:31 [PATCH] help: interpret help.autocorrect=1 as "immediate" rather than 0.1s Scott Chacon via GitGitGadget
2025-01-08 21:42 ` Kristoffer Haugsbakk
2025-01-09 0:18 ` Johannes Schindelin
2025-01-13 23:33 ` Taylor Blau
2025-01-09 1:12 ` Junio C Hamano
2025-01-09 7:05 ` Yongmin
2025-01-09 10:49 ` [PATCH v2] help: interpret boolean string values for help.autocorrect Scott Chacon via GitGitGadget
2025-01-09 16:32 ` Junio C Hamano
2025-01-10 7:43 ` Scott Chacon
2025-01-10 9:30 ` Scott Chacon
2025-01-10 12:11 ` Jeff King
2025-01-10 15:02 ` Junio C Hamano [this message]
2025-01-11 11:27 ` [PATCH v3] " Scott Chacon via GitGitGadget
2025-01-13 5:43 ` Jeff King
2025-01-13 9:31 ` Scott Chacon
2025-01-13 16:18 ` Junio C Hamano
2025-01-18 1:12 ` Junio C Hamano
2025-01-13 9:33 ` [PATCH v4] " Scott Chacon via GitGitGadget
2025-02-01 21:33 ` [PATCH 1/2] help: show the suggested command when help.autocorrect is false David Aguilar
2025-02-01 21:33 ` [PATCH 2/2] help: add "show" as a valid configuration value David Aguilar
2025-02-03 22:53 ` Junio C Hamano
2025-02-03 22:53 ` [PATCH 1/2] help: show the suggested command when help.autocorrect is false Junio C Hamano
2025-02-04 3:05 ` Jeff King
2025-02-04 13:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pxaaf0n.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=peff@peff.net \
--cc=schacon@gmail.com \
--cc=yewon@revi.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).