From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Yuri Karnilaev <karnilaev@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] revision: free commit buffers for skipped commits
Date: Fri, 30 Aug 2024 14:27:53 -0700 [thread overview]
Message-ID: <xmqq1q25r99i.fsf@gitster.g> (raw)
In-Reply-To: <20240830205331.GA1038751@coredump.intra.peff.net> (Jeff King's message of "Fri, 30 Aug 2024 16:53:31 -0400")
Jeff King <peff@peff.net> writes:
> But since this "--skip" case is an easy one-liner, it's worth fixing in
> the meantime.
OK.
> diff --git a/revision.c b/revision.c
> index ac94f8d429..2d7ad2bddf 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -4407,6 +4407,7 @@ static struct commit *get_revision_internal(struct rev_info *revs)
> c = get_revision_1(revs);
> if (!c)
> break;
> + free_commit_buffer(revs->repo->parsed_objects, c);
> }
Even if we freed the buffer and then later need it, we'd read the
buffer again anyway, so this is a safe thing to do. And because
commits skipped in this separate loop will _never_ be given to the
caller of get_revision(), this it a reasonable optimization, too.
Will queue. Thanks.
next prev parent reply other threads:[~2024-08-30 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 12:20 Unpredictable peak memory usage when using `git log` command Yuri Karnilaev
2024-08-30 20:53 ` [PATCH] revision: free commit buffers for skipped commits Jeff King
2024-08-30 21:27 ` Junio C Hamano [this message]
2024-08-30 21:06 ` Unpredictable peak memory usage when using `git log` command Jeff King
2024-08-31 10:24 ` Yuri Karnilaev
2024-09-02 13:08 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1q25r99i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karnilaev@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).