git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ghanshyam Thakkar" <shyamthakkar001@gmail.com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
	<git@vger.kernel.org>,
	 "Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] cmake: fix build of `t-oidtree`
Date: Fri, 12 Jul 2024 18:14:16 -0700	[thread overview]
Message-ID: <xmqq1q3yjdp3.fsf@gitster.g> (raw)
In-Reply-To: <D2NXQ2WZFF24.1GVN7WUJ5PCHZ@gmail.com> (Ghanshyam Thakkar's message of "Sat, 13 Jul 2024 04:34:46 +0530")

"Ghanshyam Thakkar" <shyamthakkar001@gmail.com> writes:

> Changes look correct to me. I was not aware of the existance of
> CMakeLists in the tree cause there was no mention of CMake support
> in the docs about building git from source, but it was my mistake
> for grepping for 'test-lib' in just the Makefile instead of project
> wide. Apologies for the negligance and thanks for the patch.

No need to apologize.  Nobody caught during the review, so it is not
even your fault ;-) 

And the CMakeLists is not even meant to work with anything but for
Windows, IIRC (even though it might work by accident).

  reply	other threads:[~2024-07-13  1:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 20:34 [PATCH] cmake: fix build of `t-oidtree` Johannes Schindelin via GitGitGadget
2024-07-12 20:46 ` Johannes Schindelin
2024-07-12 21:38 ` Junio C Hamano
2024-07-12 23:04   ` Ghanshyam Thakkar
2024-07-13  1:14     ` Junio C Hamano [this message]
2024-07-24 10:19     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1q3yjdp3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=shyamthakkar001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).