From: Junio C Hamano <gitster@pobox.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Jeff Hostetler via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Jeff Hostetler <jeffhostetler@github.com>
Subject: Re: [PATCH] sparse-index: pass string length to index_file_exists()
Date: Fri, 02 Feb 2024 11:30:39 -0800 [thread overview]
Message-ID: <xmqq1q9usly8.fsf@gitster.g> (raw)
In-Reply-To: <2bae709a-18da-6ab8-2b76-032ddc045641@jeffhostetler.com> (Jeff Hostetler's message of "Fri, 2 Feb 2024 14:19:17 -0500")
Jeff Hostetler <git@jeffhostetler.com> writes:
> I don't remember if this bug caused visible problems or not. It felt
> like it caused a few extra rounds of mutually-recursive calls between
> `index_file_exists()` and `expand_to_path()`, but I can't say that
> for certain (and I was focused on a different problem at the time).
>
> I do have some test code in `t/helper/lazy-init-name-hash.c` that
> I suppose we could extend to beat on it, but I'm not sure it is
> worth it in this case.
Yeah, if we had a reproduction already handy that would have been a
different story, but I agree that it is not worth it.
Thanks for a fix. Queued.
prev parent reply other threads:[~2024-02-02 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 18:04 [PATCH] sparse-index: pass string length to index_file_exists() Jeff Hostetler via GitGitGadget
2024-02-02 18:24 ` Junio C Hamano
2024-02-02 19:19 ` Jeff Hostetler
2024-02-02 19:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1q9usly8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jeffhostetler@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).