git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "Patrick Steinhardt" <ps@pks.im>,
	git@vger.kernel.org, "Matthias Aßhauer" <mha1993@live.de>
Subject: Re: [PATCH v2 0/5] ci: add support for macOS to GitLab CI
Date: Mon, 22 Jan 2024 07:44:32 -0800	[thread overview]
Message-ID: <xmqq1qa9e5jz.fsf@gitster.g> (raw)
In-Reply-To: <6e190a32-ee45-451b-b841-25cc6eb2c5ab@gmail.com> (Phillip Wood's message of "Sun, 21 Jan 2024 14:50:05 +0000")

Phillip Wood <phillip.wood123@gmail.com> writes:

> Hi Patrick
> ...
> I've read though all the patches and they seem sensible to me though
> I'm hardly a macOS expert. I did wonder about the use of pushd/popd in
> the fourth patch as they are bashisms but that matches what we're
> doing on Ubuntu already. It's nice to see the GitLab CI running on
> macOS as well as Linux now.

Thanks, both.


      parent reply	other threads:[~2024-01-22 15:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 11:44 [PATCH 0/3] ci: add support for macOS to GitLab CI Patrick Steinhardt
2024-01-15 11:44 ` [PATCH 1/3] ci: make p4 setup on macOS more robust Patrick Steinhardt
2024-01-18  7:19   ` Matthias Aßhauer
2024-01-18  9:44     ` Patrick Steinhardt
2024-01-15 11:45 ` [PATCH 2/3] Makefile: detect new Homebrew location for ARM-based Macs Patrick Steinhardt
2024-01-15 11:45 ` [PATCH 3/3] ci: add macOS jobs to GitLab CI Patrick Steinhardt
2024-01-16 14:58   ` Phillip Wood
2024-01-17  7:34     ` Patrick Steinhardt
2024-01-18 10:22 ` [PATCH v2 0/5] ci: add support for macOS " Patrick Steinhardt
2024-01-18 10:22   ` [PATCH v2 1/5] t7527: decrease likelihood of racing with fsmonitor daemon Patrick Steinhardt
2024-01-18 10:22   ` [PATCH v2 2/5] Makefile: detect new Homebrew location for ARM-based Macs Patrick Steinhardt
2024-01-18 10:22   ` [PATCH v2 3/5] ci: handle TEST_OUTPUT_DIRECTORY when printing test failures Patrick Steinhardt
2024-01-18 10:22   ` [PATCH v2 4/5] ci: make p4 setup on macOS more robust Patrick Steinhardt
2024-01-18 10:23   ` [PATCH v2 5/5] ci: add macOS jobs to GitLab CI Patrick Steinhardt
2024-01-21 14:50   ` [PATCH v2 0/5] ci: add support for macOS " Phillip Wood
2024-01-22  6:14     ` Patrick Steinhardt
2024-01-22 15:44     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1qa9e5jz.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mha1993@live.de \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).