git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  ps@pks.im,
	 Kristoffer Haugsbakk <code@khaugsbakk.name>,
	 Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2] glossary: add definitions for dereference & peel
Date: Tue, 14 Nov 2023 13:49:45 +0900	[thread overview]
Message-ID: <xmqq1qct0wie.fsf@gitster.g> (raw)
In-Reply-To: <pull.1610.v2.git.1699917471769.gitgitgadget@gmail.com> (Victoria Dye via GitGitGadget's message of "Mon, 13 Nov 2023 23:17:51 +0000")

"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:

>      * Removed references to "peeling" a commit; the updated definition
>        discusses "peeling" only in the context of tags.
>      * Added a cross-link from "dereference" to "peel" (one already existed
>        for "peel" to "dereference").
> ...
> +[[def_peel]]peel::
> +	The action of recursively <<def_dereference,dereferencing>> a
> +	<<def_tag_object,tag object>>.
> +

This was a bit surprising to me as I thought we would say "peel the
tag once" vs "peel the tag repeatedly", but upon inspecting the
existing code, documentation, and messages, we seem to mean by "to
peel" to dereference a tag repeatedly until it no longer is a tag,
which the new entry above exactly is (although "until the non-tag
object is revealed" is missing).

Thanks.  Will queue.


      reply	other threads:[~2023-11-14  4:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 23:57 [PATCH] glossary: add definitions for dereference & peel Victoria Dye via GitGitGadget
2023-11-10  0:22 ` Junio C Hamano
2023-11-10  5:20   ` Junio C Hamano
2023-11-10  8:28 ` Kristoffer Haugsbakk
2023-11-13 23:17 ` [PATCH v2] " Victoria Dye via GitGitGadget
2023-11-14  4:49   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1qct0wie.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ps@pks.im \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).