From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: John Cai <johncai86@gmail.com>,
Philippe Blain <levraiphilippeblain@gmail.com>,
John Cai via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 0/2] diff: support bare repositories when reading gitattributes for diff algorithm
Date: Thu, 16 Mar 2023 09:44:12 -0700 [thread overview]
Message-ID: <xmqq1qlomysj.fsf@gitster.g> (raw)
In-Reply-To: <ZBMn5T6zfKK+PYUe@coredump.intra.peff.net> (Jeff King's message of "Thu, 16 Mar 2023 10:29:57 -0400")
Jeff King <peff@peff.net> writes:
> If you have a static list of attributes, that is OK (though you are
> presumably better off with /etc/gitattributes or similar that covers all
> repos).
> ...
> but still tell users that "json" is a well-known name, and if they want
> to get the same treatment for an arbitrary file "foo" that they would
> get for "foo.json", they have to add attributes mapping it, like:
>
> foo diff=json
>
> inside their repo.
Yes, you described the reason very well why we didn't add "global"
or "system-wide" attribute files.
Thanks for commenting on my somewhat tongue-in-cheek "devil's
advocate" remark.
prev parent reply other threads:[~2023-03-16 16:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 1:53 [PATCH 0/2] diff: support bare repositories when reading gitattributes for diff algorithm John Cai via GitGitGadget
2023-03-14 1:53 ` [PATCH 1/2] diff: use HEAD for attributes when using bare repository John Cai via GitGitGadget
2023-03-14 16:54 ` Junio C Hamano
2023-03-14 17:43 ` Junio C Hamano
2023-03-14 19:38 ` John Cai
2023-03-14 20:37 ` Junio C Hamano
2023-03-16 16:46 ` John Cai
2023-03-16 22:56 ` Junio C Hamano
2023-03-17 14:11 ` John Cai
2023-03-14 1:53 ` [PATCH 2/2] diff: add --attr-source to read gitattributes from a commit John Cai via GitGitGadget
2023-03-14 17:21 ` [PATCH 0/2] diff: support bare repositories when reading gitattributes for diff algorithm Philippe Blain
2023-03-14 19:18 ` John Cai
2023-03-14 20:44 ` Junio C Hamano
2023-03-16 14:29 ` Jeff King
2023-03-16 16:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1qlomysj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johncai86@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).