From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] multi-pack-index: simplify handling of unknown --options
Date: Sun, 10 Jul 2022 14:54:54 -0700 [thread overview]
Message-ID: <xmqq1qusr5u9.fsf@gitster.g> (raw)
In-Reply-To: <20220710151645.GA2038@szeder.dev> ("SZEDER Gábor"'s message of "Sun, 10 Jul 2022 17:16:45 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
>> > Let parse_options() handle unknown options instead, which, besides
>> > simpler code, has the additional benefit that it prints not only the
>> > usage but an "error: unknown option `foo'" message as well.
>>
>> Yes, I agree that getting rid of KEEP_UNKNOWN is a very good idea
>> for this reason. But I suspect that we still need the "did we get
>> an extra argument we do not know what to do with?" check.
>
> Uh, indeed. I got too trigger-happy with deleting lines.
> Updated patch below.
OK. I suspect that a test would have caught the breakage in the
original. Would it make sense to add one now?
Thanks, will queue.
prev parent reply other threads:[~2022-07-10 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 20:28 [PATCH] multi-pack-index: simplify handling of unknown --options SZEDER Gábor
2022-07-08 21:08 ` Junio C Hamano
2022-07-10 15:16 ` SZEDER Gábor
2022-07-10 16:26 ` Ævar Arnfjörð Bjarmason
2022-07-10 21:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1qusr5u9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).