git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Attila Csosz <csosza@designsoftware.com>,
	git@vger.kernel.org
Subject: Re: Git bug report - disk errors on Windows after push
Date: Fri, 22 Apr 2022 09:13:27 -0700	[thread overview]
Message-ID: <xmqq1qxpcd08.fsf@gitster.g> (raw)
In-Reply-To: <220422.868rrx5uju.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 22 Apr 2022 11:27:23 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> For something like an external disk that may have its power cable yanked
> I'd give it about even odds that it's HW v.s. git's own FS syncing logic
> being at fault.

Given that the original report had this:

    Disk errors. After pushing to a directory (my origin field is C:\Work
    for example) the git repository will be corrupted.
    Moreover causing disk errors not only in the target git bare
    repository. I've loosed some other files.

that clearly stated that the corruption spreads outside repositories
managed (and written and fsynced) by Git, it does not seem likely
that Git's relying on "closing is enough as sync daemon will
eventually flush them" is the primary source of corruption.

The recent "are we fsyncing correctly?" topic is about how likely we
would survive in the presense of actions like unplugging without
unmounting.  It does not help a bit against flaky hardware, and even
when it helps, it is merely making the damage caused by such actions
less severe.

      parent reply	other threads:[~2022-04-22 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18  7:47 Git bug report - disk errors on Windows after push Attila Csosz
2022-04-18 17:37 ` brian m. carlson
2022-04-19  3:52   ` Attila Csosz
2022-04-20 21:28     ` brian m. carlson
2022-04-20 22:54     ` Neeraj Singh
2022-04-21  2:29       ` Attila Csosz
2022-04-21 20:08         ` Neeraj Singh
2022-04-22  9:27   ` Ævar Arnfjörð Bjarmason
2022-04-22 15:04     ` Attila Csosz
2022-04-22 16:13     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1qxpcd08.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=csosza@designsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).