From: Junio C Hamano <gitster@pobox.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs
Date: Thu, 12 Aug 2021 23:28:30 -0700 [thread overview]
Message-ID: <xmqq1r6xzwmp.fsf@gitster.g> (raw)
In-Reply-To: <CAPUEspg3ci4VVEU+ktDZgZkhykKbs9-+JmiOx_2CmOwFoYdMMw@mail.gmail.com> (Carlo Arenas's message of "Thu, 12 Aug 2021 15:19:02 -0700")
Carlo Arenas <carenas@gmail.com> writes:
> The advantages of using an official image will be :
>
> * more likely to be cached and therefore less likely to fail the job
> * easier to move to a newer version (specially considering 16.04 is EOL)
>
> Would it be better to drop or document it for v2?
It smells like a sensible thing to do to switch to the more
up-to-date "official" one when such a thing exists---I do not think
we have any strange dependency that makes us favor using a possibly
stale one.
It however should be a separate patch under a different title, as it
sounds like that it does not have anything to do with the "use
upload-artifacts v1" theme. So
(1) drop the hunk from this patch to make it purely about
upload-artifacts v1.
(2) add a new patch that lets us use the official image.
would be a reasonable way forward.
Thanks.
next prev parent reply other threads:[~2021-08-13 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 6:52 [PATCH] ci: use upload-artifacts v1 for dockerized jobs Carlo Marcelo Arenas Belón
2021-08-12 19:59 ` Junio C Hamano
2021-08-12 22:19 ` Carlo Arenas
2021-08-13 6:28 ` Junio C Hamano [this message]
2021-08-13 9:13 ` [PATCH v2] " Carlo Marcelo Arenas Belón
2021-08-14 22:17 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1r6xzwmp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).