From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A03C4338F for ; Fri, 13 Aug 2021 06:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C136F610CD for ; Fri, 13 Aug 2021 06:28:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238880AbhHMG3D (ORCPT ); Fri, 13 Aug 2021 02:29:03 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:51183 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238613AbhHMG3C (ORCPT ); Fri, 13 Aug 2021 02:29:02 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 31D39DA551; Fri, 13 Aug 2021 02:28:32 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=zf3Rxu0bWVTpgzMx6hbksXV+++nHXhqA7fwetN GeEjM=; b=cTCA8xLbMMj38TrnX75rarraAoTJYYhnDfAWooNqvPEHnC/hrOBkRZ 9XeAUMAwjyyRkkAdmiYDPbEIN1qaQo33wstiVMEIIzTaniRhEIcWBfojsKYNpNXu xq0ZBvSVOmQ85g6fkpp1vKJEUg85s9Q+NH1+AWZS0Mp/9P7G3dzjs= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 18161DA550; Fri, 13 Aug 2021 02:28:32 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.3.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 739ABDA54F; Fri, 13 Aug 2021 02:28:31 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Carlo Arenas Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de Subject: Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs References: <20210812065234.71399-1-carenas@gmail.com> Date: Thu, 12 Aug 2021 23:28:30 -0700 In-Reply-To: (Carlo Arenas's message of "Thu, 12 Aug 2021 15:19:02 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: ADBBB21E-FBFF-11EB-AF21-8B3BC6D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Carlo Arenas writes: > The advantages of using an official image will be : > > * more likely to be cached and therefore less likely to fail the job > * easier to move to a newer version (specially considering 16.04 is EOL) > > Would it be better to drop or document it for v2? It smells like a sensible thing to do to switch to the more up-to-date "official" one when such a thing exists---I do not think we have any strange dependency that makes us favor using a possibly stale one. It however should be a separate patch under a different title, as it sounds like that it does not have anything to do with the "use upload-artifacts v1" theme. So (1) drop the hunk from this patch to make it purely about upload-artifacts v1. (2) add a new patch that lets us use the official image. would be a reasonable way forward. Thanks.